fix(core): allow parallel schedules #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondel
approved these changes
May 2, 2022
| * Represents a work item: an input with a task and with a `result$` observable where the result (exactly one) will be streamed to. | ||
| */ | ||
| class WorkItem<TResource extends Resource, TIn, TOut> { | ||
| private readonly resultSubject = new Subject<TOut>(); |
There was a problem hiding this comment.
Small nitpick: we could also use _result$ as a name to signal it's the private version of result$
There was a problem hiding this comment.
with regards to naming: if a Subject is not exposed as an Observable, I think the name Subject can be removed from the variable name all together (see class Pool)
|
@simondel I've implemented some of the review comments and did even more improvements (made the Let's talk tomorrow about the naming standard. I tried to be consistent:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition in the
Poolclass. Previously, parallel calls to.schedule()were not supported, this PR fixes it by adding some bookkeeping to keep track of work being done in otherschedulecalls.Fixes #3473