-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add argument --dryRunOnly to only run initial tests #3814
Merged
nicojs
merged 6 commits into
stryker-mutator:master
from
florisg-infosupport:feature/3088-add-dryrun-support
Oct 29, 2022
Merged
feat: add argument --dryRunOnly to only run initial tests #3814
nicojs
merged 6 commits into
stryker-mutator:master
from
florisg-infosupport:feature/3088-add-dryrun-support
Oct 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to provide a better option to check if the Stryker configuration is correct. Prevent rollbacks, as dry-runs take less time than a full test run.
nicojs
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small remarks.
This is to remove clutter from the stryker.ts file.
nicojs
reviewed
Oct 28, 2022
The dryRunOnly name better indicates that normally dryRun is normally always run.
florisg-infosupport
changed the title
feat: add argument --dry-run to only run initial tests
feat: add argument --dryRunOnly to only run initial tests
Oct 28, 2022
nicojs
requested changes
Oct 28, 2022
…unctionality Co-authored-by: Nico Jansen <jansennico@gmail.com>
This prevents the scenario from happening that the mutations are short circuited because of empty mutations.
nicojs
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide a better option to check if the Stryker configuration is correct.
Prevent rollbacks, as a dry-run takes less time than a full test run.
closes: #3088