-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when Mutator in directive does not exist #3842
Warn when Mutator in directive does not exist #3842
Conversation
A couple of questions/issues I still have:
@nicojs Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty clever to see how you report mutants for unused stryker directives, but I don't think it's a good idea :/. Mutants are mutations in the code, not unused directives.
I think logging them as a warning is good enough for now. For example, users might want Stryker to fail fast instead of showing them in the report 🤷♀️.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🤩 , still some stuff left.
packages/instrumenter/test/unit/transformers/babel-transformer.spec.ts
Outdated
Show resolved
Hide resolved
packages/instrumenter/test/unit/transformers/babel-transformer.spec.ts
Outdated
Show resolved
Hide resolved
packages/instrumenter/test/unit/transformers/babel-transformer.spec.ts
Outdated
Show resolved
Hide resolved
02131ba
to
8a78d88
Compare
8a78d88
to
cff5c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome; just a couple of remarks left. Let me know if you need more help.
Thanks! 🎉 |
Closes #3812
When a directive references an unknown Mutator, log a warning that this directive is not used.
Mutated code
Cli