Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StrykerInitializer): Add the option to select mutators and transpilers #403

Merged
merged 7 commits into from
Oct 3, 2017

Conversation

simondel
Copy link
Member

@simondel simondel commented Oct 1, 2017

No description provided.

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Got some small remarks.

const answers = await inquirer.prompt({
type: 'checkbox',
name: 'transpilers',
message: 'What kind transformations should be applied to your code?',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the text a little bit so that it is clear that it is an optional step. Like "[optional] What kind transformations should be applied to your code?"

childExecSync.throws('error');
inquirerPrompt.resolves({ testRunner: 'ghost', reporters: [] });
});
it('should recover when install fails', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I like flatter specs

const selectedReporters = await this.selectReporters();
const npmDependencies = this.getSelectedNpmDependencies([selectedTestRunner, selectedTestFramework].concat(selectedReporters));
const npmDependencies = this.getSelectedNpmDependencies([selectedTestRunner, selectedTestFramework, selectedMutator].concat(selectedTranspilers).concat(selectedReporters));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really long line of code. Maybe we should align on some max length. It took me a while to see that transpilers were included in this list.

@simondel
Copy link
Member Author

simondel commented Oct 3, 2017

Thanks for the review! I updated the PR.

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@simondel simondel merged commit c61786f into master Oct 3, 2017
@simondel simondel deleted the mutator-transpiler-initializer branch October 3, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants