Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vitest #4043

Merged
merged 49 commits into from
May 20, 2023
Merged

Feat/vitest #4043

merged 49 commits into from
May 20, 2023

Conversation

odinvanderlinden
Copy link
Contributor

@odinvanderlinden odinvanderlinden commented Mar 18, 2023

Todo:

Optional:

  • Add option to change config file path

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't think of a huge oversight, see the comment.

packages/vitest-runner/src/vitest-file-communication.ts Outdated Show resolved Hide resolved
@TeunLamers TeunLamers mentioned this pull request Apr 12, 2023
@odinvanderlinden odinvanderlinden marked this pull request as ready for review April 28, 2023 11:49
@nicojs
Copy link
Member

nicojs commented May 15, 2023

As of vitest@0.30.0, vitest supports workspaces. This has 2 consequences:

  1. We cannot use the vitest.config anymore to set setupFiles. They now need to be set for each project in the workspace.
  2. The afterAll hook we use to write stuff to the communication dir is now being called once for each workspace. We should I think collect data inside a dir, instead of a file.

- Set minimal version to `0.30.0`
- Write coverage and hitCount per project in the workspace
- Add e2e test for workspaces
@nicojs
Copy link
Member

nicojs commented May 18, 2023

I've discovered another issue with vitest. See vitest-dev/vitest#3403. This is a show-stopper for us. 😢

@nicojs
Copy link
Member

nicojs commented May 20, 2023

I think I managed to fix all issues.

This is a list of all the workarounds/changes I've applied since @odinvanderlinden's first draft

@steschi, thanks for your reaction, but we should be able to get this working 😅

@steschi
Copy link

steschi commented May 20, 2023

@nicojs sorry, didn't wanna confuse anybody with my reaction but I can relate to some of the burden of making things work with vite from my workplace.

Generally really excited to see this landing eventually, finally getting to have proper mutation testing on a modern web application stack 😍. Did not think I'd be able to apply some of the principles thought at university within a very modern web ecosystem like vite and vitest.

Thanks for the work you and your team is doing on this and greetings from Austria! 👋🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants