Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dependencies): Pin all deps on minor version #974

Merged
merged 3 commits into from
Jul 12, 2018

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Jul 11, 2018

This PR pins all dependencies and devDependencies on minor versions. I also consolidated all commonly used dependencies to most recent (supported) versions. Namely:

Fixes #967

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

@nicojs
Copy link
Member Author

nicojs commented Jul 11, 2018

@simondel you can merge this if you're happy.

@nicojs
Copy link
Member Author

nicojs commented Jul 11, 2018

There was a rather interesting loophole here by which we still got @types for node@latest (even though we really want to make sure we support node 6, so pinned that version down). Fixed with latest commit.

@nicojs
Copy link
Member Author

nicojs commented Jul 11, 2018

Some more shenanigans with the jest integration tests... @JoshuaKGoldberg you weren't kidding

It's impossible to exactly follow semver, as even additions to an existing API can be breaking changes

@simondel
Copy link
Member

Nice job!

@simondel simondel merged commit f0a7e5a into master Jul 12, 2018
@ghost ghost removed the 🔎 Needs review label Jul 12, 2018
@simondel simondel deleted the 967-pin-minor-versions branch July 12, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants