Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use buildalyzer to identify source files #898

Merged
merged 13 commits into from
Jan 27, 2020
Merged

feat: use buildalyzer to identify source files #898

merged 13 commits into from
Jan 27, 2020

Conversation

dupdob
Copy link
Member

@dupdob dupdob commented Jan 22, 2020

Fix #897. No unit tests due to an exploration based approach.
Old scanning logic still present in case buildalyzer completely fails

@dupdob
Copy link
Member Author

dupdob commented Jan 22, 2020

/azp run (it was worth a try)

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 898 in repo stryker-mutator/stryker-net

1 similar comment
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 898 in repo stryker-mutator/stryker-net

@rouke-broersma
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rouke-broersma
Copy link
Member

/azp run (it was worth a try)

Sorry :p You need permission on azure devops to be able to do that.

@dupdob
Copy link
Member Author

dupdob commented Jan 24, 2020

FYI: I have constant issues with nuget (error nu1403, hash changed), hence I have to juggle with packages.lock.json.
Any pointer on how to fix this will be very appreciated.

4>C:\Users\dupdob\source\repos\stryker-net\src\Stryker.Core\Stryker.Core.UnitTest\Stryker.Core.UnitTest.csproj : error NU1403: Package content hash validation failed for System.Reflection.4.3.0. The package is different than the last restore.
4>C:\Users\dupdob\source\repos\stryker-net\src\Stryker.Core\Stryker.Core.UnitTest\Stryker.Core.UnitTest.csproj : error NU1403: Package content hash validation failed for System.Reflection.Emit.4.3.0. The package is different than the last restore.
4>C:\Users\dupdob\source\repos\stryker-net\src\Stryker.Core\Stryker.Core.UnitTest\Stryker.Core.UnitTest.csproj : error NU1403: Package content hash validation failed for System.Reflection.Emit.ILGeneration.4.3.0. The package is different than the last restore.

@rouke-broersma
Copy link
Member

@dupdob That issue is due to a bug in previous versions of dotnet core... :(

See: NuGet/Home#7921 (comment)

Luckily this is only an issue if you have previously contributed to stryker. Something with the hashes being calculated wrong in something called 'NugetFallbackLocation' which keeps being an issue if you have ever had packages downloaded into there..

These steps should help you fix it for your system:

dotnet nuget locals all --clear
git clean -xfd
git rm **/packages.lock.json -f
dotnet restore Stryker.CLI.sln

@richardwerkman
Copy link
Member

Could you add some unit tests for the InputFileResolver? It contains a lot of new code that seems important 😄

@dupdob
Copy link
Member Author

dupdob commented Jan 24, 2020

Added a unit test

@richardwerkman
Copy link
Member

The code looks good but the build seems to fail on linux? I'll try running again to see if it was a random encounter

@richardwerkman
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardwerkman
Copy link
Member

I have tested your code on a project and indeed I see buildalyzer provides a set of files. I don't know why it didnt work when I tried a few weeks ago. But that is great news 🎉

@richardwerkman
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dupdob
Copy link
Member Author

dupdob commented Jan 24, 2020

it looks a random event, since previous run (with the weak unit test) ran fine.
It looks like failing to resolve dependencies, so there may be an issue somewhere

@rouke-broersma
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rouke-broersma
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rouke-broersma rouke-broersma merged commit f2f219d into stryker-mutator:master Jan 27, 2020
@rouke-broersma
Copy link
Member

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support source file identification with buildalizer
3 participants