-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds option for user to use their own, "custom" word list #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g built-in word lists as Strings or in Vectors
Should we merge this, adding code complexity but also the ability for users to use their own word list? Pros (of merging)
Cons
Note: Pgen doesn't accept custom word lists, but passphraseme does. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9.
Also implements a (case-sensitive) check for duplicates, plus a check for non-uniform Unicode Normalization, on the user-provided lists, hopefully removing some footguns.
I got
generate_passphrase
to take both&' static [&str]
when using a built-in list andVec<String>
when handling a user-provided list, thanks to some Ugly Rust trickery:What I'd like to improve in this PR
The bummer with this PR as it stands is how ugly
src/main.rs
is now.and later
I'd love to have one type
List
that can handle both&' static [&str]
when using a built-in list andVec<String>
when handling a user-provided list.I'm guessing I'll need to implement a trait of some kind? I'm trying to sketch out the problem in a Rust playground, but it's hard going for me!