Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a build script #2

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Use a build script #2

merged 7 commits into from
Oct 24, 2023

Conversation

sts10
Copy link
Owner

@sts10 sts10 commented Oct 22, 2023

Theoretically, this will make runtime faster.

PR takes instruction from: Rust docs and Pgen.

@sts10
Copy link
Owner Author

sts10 commented Oct 22, 2023

In actual benchmarks with Hyperfine...

hyperfine --setup 'cargo install --force --path=.' -w 2000 -m 3000 -N phraze

This PR is about even with the main branch, which does not use a build script. Kind of a bummer! That said, with either setup we're averaging 1.5 ms, so not bad.

Note: pgen runs in a mean of 1.3 ms on my machine, but I'm not worried.

@sts10 sts10 merged commit de24e9b into main Oct 24, 2023
@sts10
Copy link
Owner Author

sts10 commented Oct 24, 2023

Well, turns out that by using Criterion, we see that the method of using a build script is about 500x faster, so I've merged this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant