Proj 1 dev #4
Merged
Proj 1 dev #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 1 : VPC created Add 2 : Public, private subnet added at each .tf file Add 3 : igw , public route table added, no route rule yet Add 3 : nat , eip_for_nat, private route table added => Add 3 is not completed. It will be completed at next time.
Step 1 make vpc -> project1_dev로 merge를 승인합니다.
step 2 - adjust custom vpc(instead of default one) completed VPC include 3 tier subnet (web, was, db). And each subnet contains auto scaling group and load balancer, and simple apache server to health check. Next time, deploy monitoring system and maybe web was db software.
Step 2 add vpc to alb asg
Project 1 completed.
Modified 1 : public, app, db -> web, was, db
Modified 2 : ALB positioned at public subnet, and web tier goes to private subnet
Modified 3 : subnet {pub, app, db} -> subnet {pub, web, was, db}, so public cidr splitted to pub and web
ADD 1 : print output ip and domain names of ELB
ADD 2 : Use user data instead of using direct code
…system Ds 50 . step 3 deploy monitoring system
|
review required는 여기다가 한줄 적으면 되는 걸까요? |
sts2885
commented
May 7, 2023
| 10. dash board import | ||
|
|
||
| 제 블로그를 참고해주신다면 감사하겠습니다.(그냥 들어가서 datasource만 추가해주면 됩니다.) | ||
| https://cherry-blossome-in-march.tistory.com/5 |
There was a problem hiding this comment.
세상에 merge 해보기 위해서 code review라는 걸 처음으로 해봤네요! im-d-team/Dev-Docs#11 여기서 하는 법을 알게 됐어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
프로젝트 1이 마무리 되었으니, main으로 release 합니다. 언젠가는 release branch를 만들어서 운영했으면 좋겠네요!