-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API/DOC/backwards: rework config defaults #125
Conversation
Some recommendations:
|
All tests pass locally for commit 72152a2. On CI, one test is failing (looks like a left-over from a previous test to make sure backend errors are logged). |
I've fixed the CI tests, and have accelerated them.
The time spent in the CI went from 37-38 minutes to 14-15 minutes. |
0d27d59
to
13ee3fc
Compare
bump
clean up validation sampling test
better clearing of logs? better clear logs more printing bg same process
don't print synchronous save wrap save/bgsave to catch error better sleep on save don't sleep
narrow try/except
have some built in delay for Logs
bump bump
I've reworked resetting samplers. I think this closes #82. After hitting As a result, the CI works now. |
Now, hitting |
What does this PR implement?
It changes the defaults for Salmon.
alg_ident
tosampler
./config
can be uploaded to/init
.n
has been removed from/config
).Reference issues/PRs
Closes #124, closes #82 and closes #115.