fix(tab):Separate tab body #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gulcinuras
reviewed
Jan 22, 2023
There was a problem hiding this comment.
@tatata96 as far as I understand from the mentioned issue, we should have a compound components (could be named as TabHeader and TabBody) which would allow us to customize easier. So, I think we should follow a similar atomized approach as we have in the Select component. What do you think?
ErenYLCN
suggested changes
Jan 23, 2023
There was a problem hiding this comment.
I agree with @gulcinuras here, I think we should at least have a TabHeader component to completely fulfill the issue
|
I also agree with @gulcinuras. We should have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue;