feat!: upgrade league/fractal to 0.20
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to most recent branch of `league/fractal`. This makes sense to do now since `craftcms/element-api` has also done this upgrade in its recent 4.x line. BREAKING CHANGE: Fractal's public API has changed in classes such as `\League\Fractal\Serializer\ArraySerializer`
|
I think the Craft 5 release and the new major version is probably to best place to introduce this change. I'll update the base branch to develop-v5 and merge it when I prepare the next beta release later this week. |
|
I just read about https://getcomposer.org/doc/04-schema.md#conflict, and that could probably be used on the current 3.x version? So that it helps users not upgrade to element API 4.x whilst still using Scout 3.x. What do you think? |
|
3.4.1 is out with the conflict for craftcms/element-api >=4.0.0, and 4.0.0 is out the the fractal update and the version conflict for craftcms/element-api < 4.0.0. Thanks again for the PR @qrazi! |
|
Thanks @janhenckens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to most recent branch of
league/fractal. This makes sense to do now sincecraftcms/element-apihas also done this upgrade in its recent 4.x line. This should probably also be ported to the v5-develop branch, or maybe only introduce with that branche?BREAKING CHANGE: Fractal's public API has changed in classes such as
\League\Fractal\Serializer\ArraySerializer