Fix for elements not being deindexed when indexRelations config is false and queue is enabled #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When indexRelations config is false and the queue is used, the DeindexElement queue job is not reached in the before delete element event. This results in the element not be deindexed. Removing the return here ensures the queue job gets pushed.
|
Thanks for catching that! I'll make sure this gets release in the Craft 4 & 5 versions - I'm away on holiday at the moment so it could be another week or 2 before I get the fix out. |
|
Thanks @mike-moreau, this fix is included in today's release (4.1.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
indexRelationsconfig is set tofalseand the queue is used, the DeindexElement queue job is not reached in the before delete element event.This results in the element not be deindexed in Algolia.
Removing the return here ensures the queue job gets pushed.