missing dependencies on wordpress 6.4 #168

signsi · 2023-11-08T11:34:51Z

Bug summary

On wordpress 6.4 our custom blocks based on genesis are no longer displayed in the editor.

The first issues is that wordpress dropped lodash but genesis seems to need it, possibly without properly requesting it.
The second issue is: TypeError: undefined is not an object (evaluating 'rn.debounce').

The first issues can be quickfixed by explicitly loading lodash for example a script which is loaded in the editor. We are currently still looking for quickfixes for the second issue.

Steps to reproduce

Update wordpress to 6.4
Check genesis custom blocks in the editor
check the browser console for errors

Expected behavior

The Plugin should properly work with all stable version of wordpress.

Actual behavior

Multiple js errors. On the frontend side it still seems to work.

JS Console

TypeError: undefined is not an object (evaluating 'rn.debounce')
value — block-editor.js:2:71662
Jr — react-dom.min.js:4273
Zr — react-dom.min.js:4254:94
Gr — react-dom.min.js:4227
(anonymous function) — react-dom.min.js:5027
xl — react-dom.min.js:5051
fl — react-dom.min.js:4630:82
Nn — react-dom.min.js:1856
(anonymous function) — react-dom.min.js:4462

Additional information

Suspected cause (optional)

It looks like a missing functions (debounce). Possibly it is due to a version conflict of react dom.

Versions

WordPress version: 6.4
Genesis Custom Blocks version: 1.5.3 via wpmudev / 1.5.2 via github (both don't work, why is this discrepancy?)
OS: Mac
Browser: Safari
Device: MBP

The text was updated successfully, but these errors were encountered:

kienstra · 2023-11-08T14:38:27Z

Hi @signsi,
Thanks for letting me know about this.

It sounds like there aren't any other plugins active on your site, right?

I'm not seeing this error, and the e2e tests are passing with 6.4.

kienstra · 2023-11-08T14:45:28Z

PS. Thanks for your very detailed report.

kienstra · 2023-11-08T14:47:01Z

Genesis Custom Blocks version: 1.5.3 via wpmudev / 1.5.2 via github (both don't work, why is this discrepancy?)

Good question, we've never released a version 1.5.3, that's strange.

signsi · 2023-11-08T14:58:20Z

Hey @kienstra

I've also informed wpengine. We have version 1.5.3 from there. What is the connection there? The error exists with all versions. I also have the error with the default theme and without other plugins.

Regarding lodash, the clean solution is probably that the dependency is explictly specified. Lodash is still available in the core, but is no longer automatically enqueued.

I've just downloaded the version from the repo here. So far updates of the wordpress / react dependencies have not helped so far.

signsi · 2023-11-08T15:20:45Z

Quick update: The problem with lodash seems to be due to a combination of genesis custom blocks and our theme (since 6.4). However, the problem with the debounce always exists.

kienstra · 2023-11-08T15:38:34Z

I've also informed wpengine. We have version 1.5.3 from there. What is the connection there?

Ah, so that's Genesis Custom Blocks Pro. This repo is for the free version deployed to wp.org.

Genesis Custom Blocks Pro also runs GCB free, though.

kienstra · 2023-11-08T15:41:21Z

Regarding lodash, the clean solution is probably that the dependency is explictly specified. Lodash is still available in the core, but is no longer automatically enqueued.

Hm, GCB enqueues lodash, I'm not sure what more we can do with that.

signsi · 2023-11-08T15:43:29Z

Regarding lodash, the clean solution is probably that the dependency is explictly specified. Lodash is still available in the core, but is no longer automatically enqueued.

Hm, GCB enqueues lodash, I'm not sure what more we can do with that.

That issue was not related to the plugin.

kienstra · 2023-11-08T15:44:08Z

Ah, thanks.

kienstra · 2023-11-08T15:45:32Z

I'm looking at rn.debounce, it's hard to see where that's coming from.

signsi · 2023-11-08T15:47:05Z

I was also able to reproduce the error on a bare WP installation on a standard web server. So I'm pretty sure it's due to the combination of WP 6.4 and Genesis Custom Blocks.

TypeError: undefined is not an object (evaluating 'rn.debounce')
value — block-editor.js:2:71662
Jr — react-dom.min.js:10:80732
Zr — react-dom.min.js:10:80492
Gr — react-dom.min.js:10:80026
(anonymous function) — react-dom.min.js:10:91529
xl — react-dom.min.js:10:92040
fl — react-dom.min.js:10:85811
Nn — react-dom.min.js:10:32476
(anonymous function) — react-dom.min.js:10:83229

kienstra · 2023-11-08T15:49:49Z

OK, thanks. I don't see that error.

Would you be able to run this plugin from source to see if that gives a better error message?

git clone https://github.com/studiopress/genesis-custom-blocks
cd genesis-custom-blocks
nvm use && npm ci && npm run dev

signsi · 2023-11-08T15:51:11Z

I'm looking at rn.debounce, it's hard to see where that's coming from.

I totally agree. Tried it some hours ago myself.
Not sure if this helps but: When I create a new page and insert the block, everything seems to be correct. Only when I click out or save does the error appear.

kienstra · 2023-11-08T15:55:58Z

Only when I click out or save does the error appear.

OK, thanks. I'll do that.

kienstra · 2023-11-08T15:57:13Z

Sorry, still not seeing the error. I'll think about this today.

signsi · 2023-11-08T16:02:27Z

I tried the same thing today. But I used the build instead of the dev server.
So the plugin runs from the source code, in dev mode. The error has changed. We are back to lodash.

TypeError: undefined is not an object (evaluating 'lodash__WEBPACK_IMPORTED_MODULE_8__.debounce')
componentDidMount — server-side-render.js:64
Jr — react-dom.min.js:10:80732
Zr — react-dom.min.js:10:80492
Gr — react-dom.min.js:10:80026
(anonymous function) — react-dom.min.js:10:91529
xl — react-dom.min.js:10:92040
fl — react-dom.min.js:10:85811
Nn — react-dom.min.js:10:32476
(anonymous function) — react-dom.min.js:10:83229

signsi · 2023-11-08T16:17:31Z

Here you will find the source code. It is from the package @wordpress/server-side-render in version 1.19.5.

kienstra · 2023-11-08T16:40:53Z

Wow, great find.

So debounce is undefined.

signsi · 2023-11-08T18:45:19Z

Yes, that's how it looks at the moment. I'll take another deep dive into the matter tomorrow.
Thanks Ryan!

kienstra · 2023-11-08T18:50:46Z

Thanks, talk to you tomorrow!

kienstra · 2023-11-09T01:21:16Z

The e2e tests are showing the same error about debounce.

signsi · 2023-11-09T07:27:32Z

Hey Ryan
Great, so now we have confirmation that it's not just down to our setup. I'll get back to you later.
Thanks!

signsi · 2023-11-09T08:56:37Z

We've just discussed the issue internally. This warning could potentially be related as the refactoring to hooks also concerned these (or at least related) packages:
wp.compose.withState is deprecated since version 5.8. Please use wp.element.useState instead.

signsi · 2023-11-09T09:01:10Z

To be more precise: the warning clearly comes from wp core.

signsi · 2023-11-09T09:38:45Z

Work in progress: Testing @wordpress/server-side-render@4.3.8. Currently it looks much better. Doing some proper testing now. In Version 4.3.8 the refactoring to hooks is present.

fabiankaimer · 2023-11-09T12:24:06Z

Hi guys,
just wanted to let you know that I experience the exact same issue as @signsi with Wordpress 6.4.1 and Genesis Custom Blocks 1.5.2:

Downgrading Wordpress back to 3.6.x does resolve the issue temporarily. Thanks already to you for taking care of this!

signsi · 2023-11-09T12:34:14Z

Hello @fabiankaimer
Thanks for letting us know. Our manual tests in Wordpress look good so far. I am working on running the e2e tests.

kienstra · 2023-11-09T14:05:23Z

Hi @signsi,
What does it show when you enter lodash in the JS console?

kienstra · 2023-11-09T15:01:15Z

Does this .zip fix it on your site?

genesis-custom-blocks.1.5.2.zip

It's from #170, which at least passes the e2e tests.

vishu87 · 2023-11-09T15:17:43Z

Hi @kienstra

I was also facing this issue, but replacing the plugin which this zip file removes the problem for me on WP 6.4.1

kienstra · 2023-11-09T15:26:39Z

@vishu87,
Thanks a lot for testing that, good to hear.

signsi · 2023-11-09T15:26:58Z

@kienstra same for me. ✅

kienstra · 2023-11-09T15:28:15Z

@signsi,
Great to hear, thanks a lot for testing it and reporting this.

signsi · 2023-11-09T15:34:24Z

Thanks, for the PR @kienstra . Thanks, for the PR. So it was really missing JS dependencies, more precisely lodash?

kienstra · 2023-11-09T15:36:19Z

Yeah, it was missing lodash, you called it 😄

kienstra · 2023-11-09T15:37:24Z

I might not release this fix to wp.org until next week, Thursday is getting a late for a release 😄

signsi · 2023-11-09T15:50:58Z

Sure, no worries. Thanks Ryan. For the pro-version it might take even more time, right?

kienstra · 2023-11-09T15:53:18Z

For the pro-version it might take even more time, right?

No, I'll release the Pro version the same day as the free version.

bringsonline · 2023-11-09T16:16:00Z

Replacing the plugin with the one in the zip-file worked for me as well, problem solved. Thanks a lot @kienstra

kienstra · 2023-11-09T16:29:34Z

Thanks, @bringsonline! Great to hear.

kienstra · 2023-11-09T18:38:26Z

Hi @signsi,
The fix for this is released in Genesis Custom Blocks free and Pro 1.6.0.

In wp-admin/plugins/php, you should see a notice soon to update your GCB Pro to 1.6.0.

fabiankaimer · 2023-11-09T20:00:15Z

Thanks for the quick fix. Works again for me as well!

kienstra · 2023-11-09T20:57:42Z

Thanks, @fabiankaimer! Good to hear!

signsi · 2023-11-10T06:09:38Z

Hi @signsi, The fix for this is released in Genesis Custom Blocks free and Pro 1.6.0.

In wp-admin/plugins/php, you should see a notice soon to update your GCB Pro to 1.6.0.

Great, thanks a lot.

kienstra mentioned this issue Nov 9, 2023

Enqueue block-editor.js dependencies that I didn't enqueue before #170

Merged

kienstra closed this as completed in #170 Nov 9, 2023

missing dependencies on wordpress 6.4 #168

missing dependencies on wordpress 6.4 #168

Comments

signsi commented Nov 8, 2023

Bug summary

Steps to reproduce

Expected behavior

Actual behavior

JS Console

Additional information

Suspected cause (optional)

Versions

kienstra commented Nov 8, 2023 • edited Loading

kienstra commented Nov 8, 2023

kienstra commented Nov 8, 2023 • edited Loading

signsi commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023 • edited Loading

kienstra commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023

kienstra commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023

kienstra commented Nov 8, 2023

signsi commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023

signsi commented Nov 8, 2023

kienstra commented Nov 8, 2023

kienstra commented Nov 9, 2023

signsi commented Nov 9, 2023

signsi commented Nov 9, 2023

signsi commented Nov 9, 2023

signsi commented Nov 9, 2023

fabiankaimer commented Nov 9, 2023

signsi commented Nov 9, 2023 • edited Loading

kienstra commented Nov 9, 2023

kienstra commented Nov 9, 2023

vishu87 commented Nov 9, 2023

kienstra commented Nov 9, 2023

signsi commented Nov 9, 2023

kienstra commented Nov 9, 2023

signsi commented Nov 9, 2023

kienstra commented Nov 9, 2023 • edited Loading

kienstra commented Nov 9, 2023

signsi commented Nov 9, 2023

kienstra commented Nov 9, 2023

bringsonline commented Nov 9, 2023

kienstra commented Nov 9, 2023

kienstra commented Nov 9, 2023 • edited Loading

fabiankaimer commented Nov 9, 2023

kienstra commented Nov 9, 2023

signsi commented Nov 10, 2023

kienstra commented Nov 8, 2023 •

edited

Loading

kienstra commented Nov 8, 2023 •

edited

Loading

kienstra commented Nov 8, 2023 •

edited

Loading

signsi commented Nov 9, 2023 •

edited

Loading

kienstra commented Nov 9, 2023 •

edited

Loading

kienstra commented Nov 9, 2023 •

edited

Loading