Enqueue block-editor.js dependencies that I didn't enqueue before
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
commented
Nov 9, 2023
| @@ -134,7 +134,7 @@ public function editor_assets() { | |||
| wp_enqueue_script( | |||
| $js_handle, | |||
| $this->assets['url']['entry'], | |||
| [], | |||
There was a problem hiding this comment.
I made the dependencies argument [] instead of $js_config['dependencies'] in c347a98.
That was to prevent this PHP warning on /wp-admin/widgets.php:
Notice: Function wp_enqueue_script() was called incorrectly. "wp-editor" script should not be enqueued together with the new widgets editor (wp-edit-widgets or wp-customize-widgets). Please see Debugging in WordPress for more information. (This message was added in version 5.8.0.) in wp-includes/functions.php on line 6031
There was a problem hiding this comment.
But that warning is less important now.
Default themes like Twenty Twentythree don't have widgets, and widgets are soft-deprecated in favor of site editing.
This was referenced Nov 9, 2023
|
CI/CD will pass once we merge #171 |
Merged
|
Replicated: Fixed on this branch: |
johnstonphilip
approved these changes
Nov 9, 2023
|
Thanks so much, @johnstonphilip! Good to see your screenshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
block-editor.jsdependencies that I didn't enqueue beforeFixes #168