Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of REMs #105

Closed
bgardner opened this issue Apr 15, 2018 · 4 comments
Closed

Removal of REMs #105

bgardner opened this issue Apr 15, 2018 · 4 comments

Comments

@bgardner
Copy link
Contributor

Wanted to throw this up for discussion, based R.I.P. REM, Viva CSS Reference Pixel!.

Discuss.

@bgardner
Copy link
Contributor Author

Anybody have any thoughts on this? We've discussed this, and have seen lots of articles that go both ways on this. Curious what others think.

@nickcernis
Copy link
Collaborator

nickcernis commented Apr 30, 2018

I think we can safely drop rems.

For accessibility, because modern browsers adequately resize text regardless of how the size has been defined, it is not vital that text sizes be defined in relative sizes.

— from https://webaim.org/techniques/fonts/#font_size,
and also quoted in https://make.wordpress.org/accessibility/handbook/best-practices/design/font-sizes-and-resize-text/#relative-units-vs-absolute-units

I still see vague suggestions in recent design guidelines and blog posts to use rems/ems for accessibility, but the articles never state why or which browsers this is a requirement for. For example, this is from Google's a11y guidelines:

Also, consider using relative units like em or rem for things like text size, instead of pixel values. Some browsers support resizing text only in user preferences, and if you're using a pixel value for text, this setting will not affect your copy. If, however, you've used relative units throughout, then the site copy will update to reflect the user's preference.

https://developers.google.com/web/fundamentals/accessibility/accessible-styles (updated January 3, 2018)

The WCAG doc for font sizing mentions that relative units are good for accessibility:

When you click through to the “User Agent Support Notes” to find out which browsers are affected by this, they mention IE 7:

When font size is specified in any absolute units of measurement, such as points or pixels, the Text Size menu commands in Internet Explorer 7 and earlier do not resize the text.

As we don't claim to support IE 7 this may be a non-issue.

I found one comment in a Medium post that IE 10 still does not support font scaling of absolute-sized fonts, but I couldn't reproduce this when testing in IE 10.

@bgardner
Copy link
Contributor Author

@dreamwhisper @nathanrice Giving you right of first refusal here. :-)

bgardner added a commit that referenced this issue Jul 17, 2018
@nickcernis
Copy link
Collaborator

Noting a similar discussion in the Gutenberg repo in case this comes up again: WordPress/gutenberg#6454

nickcernis pushed a commit that referenced this issue Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants