Incorrect built-in scalars #83
Labels
bug
Something isn't working
Comments
stuebingerb
added a commit
that referenced
this issue
Jan 12, 2025
Partially resolves #83 by splitting up the current `BuiltInScalars` into two: - The actual built-in scalars as defined by the spec - Some extended scalars supported by KGraphQL Breaking: Those extended scalars are no longer automatically added to a schema but must be manually included using `extendedScalars()` if needed.
stuebingerb
added a commit
that referenced
this issue
Jan 12, 2025
Partially resolves #83 by splitting up the current `BuiltInScalars` into two: - The actual built-in scalars as defined by the spec - Some extended scalars supported by KGraphQL BREAKING CHANGE: Those extended scalars are no longer automatically added to a schema but must be manually included using `extendedScalars()` if needed.
stuebingerb
added a commit
that referenced
this issue
Jan 12, 2025
Partially resolves #83 by splitting up the current `BuiltInScalars` into two: - The actual built-in scalars as defined by the spec - Some extended scalars supported by KGraphQL BREAKING CHANGE: Those extended scalars are no longer automatically added to a schema but must be manually included using `extendedScalars()` if needed.
stuebingerb
added a commit
that referenced
this issue
Jan 13, 2025
Partially resolves #83 by splitting up the current `BuiltInScalars` into two: - The actual built-in scalars as defined by the spec - Some extended scalars supported by KGraphQL BREAKING CHANGE: Those extended scalars are no longer automatically added to a schema but must be manually included using `extendedScalars()` if needed. BREAKING CHANGE: Shorts are returned as numeric value, no longer as string.
stuebingerb
added a commit
that referenced
this issue
Jan 14, 2025
Partially resolves #83 by splitting up the current `BuiltInScalars` into two: - The actual built-in scalars as defined by the spec - Some extended scalars supported by KGraphQL BREAKING CHANGE: Those extended scalars are no longer automatically added to a schema but must be manually included using `extendedScalars()` if needed. BREAKING CHANGE: Shorts are returned as numeric value, no longer as string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
KGraphQL currently defines the following built-in scalars:
However, the spec defines the following:
According to the spec, those must be supported and also behave in a special way during introspection (which likely is not correctly implemented either).
So:
IMHO, Short and Long can still be included as built-in "extended" types to save users of the library from having to define them on their own but they must not behave like GraphQL built-in types. We can then also think about adding other common JVM types to those extended built-ins.
The text was updated successfully, but these errors were encountered: