test(benchmark): make benchmarks runnable #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuebingerb
reviewed
Jan 24, 2025
kgraphql/src/jvm/kotlin/com/apurebase/kgraphql/BenchmarkSchema.kt
Outdated
Show resolved
Hide resolved
kgraphql/src/jvm/kotlin/com/apurebase/kgraphql/ParallelExecutionBenchmark.kt
Outdated
Show resolved
Hide resolved
stuebingerb
approved these changes
Jan 27, 2025
|
|
||
| private val query = buildString { | ||
| append("{") | ||
| (0..999).forEach { appendLine("automated$it".prependIndent(" ")) } |
There was a problem hiding this comment.
What's the benefit of prependIndent here? Formatting shouldn't matter for execution, should it?
There was a problem hiding this comment.
There isn't any, it was just for manual reviewing of the query.
mervyn-mccreight
force-pushed
the
test/benchmarks
branch
from
e13a27c to
2e898e5
Compare
The benchmarks have been excluded from the build for quite a while. Repair and re-add the benchmarks to the Gradle build.
mervyn-mccreight
force-pushed
the
test/benchmarks
branch
from
2e898e5 to
3b7af76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks have been excluded from the
build for quite a while. Repair and re-add the
benchmarks to the Gradle build.
Resolves #50