Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct crash on AD with special chars (french, german, etc.).
Crash example:
[20/May/16 12:02:14] Parsing LDIF...
Reading line 4817/3610393 (0%)Traceback (most recent call last):
File "adoffline.py", line 481, in
process_struct(current_dn,sql)
File "adoffline.py", line 56, in process_struct
insert_into_db(struct,sql)
File "adoffline.py", line 264, in insert_into_db
c.execute(sql_statement, ldap_values)
sqlite3.ProgrammingError: You must not use 8-bit bytestrings unless you use a text_factory that can interpret 8-bit bytestrings (like text_factory = str). It is highly recommended that you instead just switch your application to Unicode strings.