Merge pull request #4 from mcampbell/use-array-sample-vs-homegrown

Use builtin Array#sample vs "manual" random indexing
stulzer · May 11, 2024 · cd7b965 · cd7b965
2 parents 23eba56 + fbfa452
commit cd7b965
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/cuid2.rb b/lib/cuid2.rb
@@ -13,7 +13,7 @@ def self.create(length)
       entropy = ''
 
       while entropy.length < length
-        random_prime = PRIMES[(rand * PRIMES.size).floor]
+        random_prime = PRIMES.sample
         entropy += (rand * random_prime).floor.to_s(36)
       end
 
@@ -42,7 +42,7 @@ def self.create(input, length = BIG_LENGTH)
 
   class << self
     def call(length = DEFAULT_LENGTH)
-      random_letter = ('a'..'z').to_a[(rand * 26).floor]
+      random_letter = ('a'..'z').to_a.sample
       hash_input = (time + Entropy.create(length) + count + fingerprint).to_s
 
       "#{random_letter}#{Cuid2::Hash.create(hash_input, length)[2..length]}"