Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Provision session tokens on successful auth #219

Closed
aaronleopold opened this issue Dec 11, 2023 · 1 comment
Closed

[FEATURE] Provision session tokens on successful auth #219

aaronleopold opened this issue Dec 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@aaronleopold
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Future development towards Windows desktop builds will be blocked by a Windows issue where webview2 blocks the cookies the server sends. macOS and Linux seem otherwise unaffected.

Describe the solution you'd like

Support sending some sort of token that can be used in the interface, this way the issue of the blocked cookie does not matter. This should ideally work alongside the server-side auth, as I don't necessarily want to remove that system (useful in existing features like log out on all devices, etc).
@aaronleopold aaronleopold added the enhancement New feature or request label Dec 11, 2023
@aaronleopold aaronleopold added this to the Desktop application milestone Dec 13, 2023
@aaronleopold aaronleopold removed this from the Desktop application milestone Feb 26, 2024
aaronleopold added a commit that referenced this issue Aug 15, 2024
@aaronleopold
wip: axum upgrade and refactor auth extractor to support jwt
73f3a2d 
relates to #219
@aaronleopold aaronleopold mentioned this issue Aug 16, 2024
Merged
aaronleopold added a commit that referenced this issue Aug 17, 2024
@aaronleopold
♻️ Update axum and refactor middlewares (#400)
e613d95 
* wip: upgrade axum et al, many breaking changes

little lunch rush

* wip: axum upgrade and refactor auth extractor to support jwt

relates to #219

* lots of refactoring for axum

* add migration, make clippy warn on `dbg` macro

* add curl to dockerfile
aaronleopold added a commit that referenced this issue Aug 18, 2024
@aaronleopold
♻️ Update axum and refactor middlewares (#400)
f643885 
* wip: upgrade axum et al, many breaking changes

little lunch rush

* wip: axum upgrade and refactor auth extractor to support jwt

relates to #219

* lots of refactoring for axum

* add migration, make clippy warn on `dbg` macro

* add curl to dockerfile
@github-project-automation github-project-automation bot moved this to Backlog in v0.1.x Oct 14, 2024
@aaronleopold aaronleopold moved this from Backlog to In Progress in v0.1.x Oct 14, 2024
@aaronleopold
Copy link
Collaborator Author

This is largely completed. The one bit of work I'd like to add as a future enhancement is a better refresh token flow. For the time being, the only client which uses tokens is the desktop app which isn't even released yet so this should be acceptable.

Also, for posterity, the cookie issues are no longer unique to Windows. After migrating to tauri v2 it seemed to present in macOS too.

@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.1.x Oct 16, 2024
@aaronleopold aaronleopold mentioned this issue Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
v0.1.x
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronleopold