Fixed for 0.35.0

[bararchy]

No description provided.

[l3kn]

Thanks!

Do you think the version of stumpy_png should change from v4.5.2 to v5.0.0 with this?

From a quick look at the crystal docs, it seems like this would be a backwards-incompatible with crystal versions < 0.35.

[Sija]

@l3kn IIRC it should be BC

[vlazar]

@l3kn Support both? crystal-lang/crystal-mysql@99cc05d#diff-6026e397c04cfe7a845128029e20a18dR33

[bararchy]

@vlazar I think that as we are in unstable land still and pre 1.0.0 it's ok to break. I wouldn't add logic to support old crystal versions, were not there yet ;)

[oprypin]

I think it's nice to support both.

[da1nerd]

@l3kn putting aside the fact that crystal is still pre 1.0. I'd suggest ticking with the standard, that is, go ahead and bump to 5.0 since this is a breaking change as I understand it.

[da1nerd]

FYI there's some discussion over in this PR schovi/baked_file_system#36 (practically identical to this one) on whether or not returning slice.size.to_i64 is sufficient.

It might be good to keep an eye on the outcome of that conversation.

[bararchy]

@l3kn this PR shouldn't be merged as it seems Crystal is reverting this change.

[l3kn]

@bararchy Ok, I'll close this for now.

For further reference:

• Revert IO#write changes in 0.35.0 and let it return Nil crystal-lang/crystal#9469
• Make IO#skip IO#write returns the number of bytes it skipped/written crystal-lang/crystal#9233 (comment)