Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it work with Crystal 0.35/1.0.0 #31

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Make it work with Crystal 0.35/1.0.0 #31

merged 2 commits into from
Aug 28, 2020

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Aug 23, 2020 •
edited
Loading

@Sija Sija mentioned this pull request Aug 23, 2020
Merged
@l3kn
Copy link
Collaborator

l3kn commented Aug 27, 2020

I assume this won't work with some older crystal versions,
should we change the major version of stumpy_png with this?

@Sija
Copy link
Contributor Author

Sija commented Aug 27, 2020

@l3kn

I assume this won't work with some older crystal versions,

Correct (older meaning < 0.35).

should we change the major version of stumpy_png with this?

Yup, I think we should - good point!

@l3kn l3kn merged commit b5dd306 into stumpycr:master Aug 28, 2020
@l3kn
Copy link
Collaborator

l3kn commented Aug 28, 2020

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors after upgrading to Crystal 0.35.0 0.35.0 Fixes
2 participants
@Sija @l3kn