Add color depth parameter to SpatialVideoMerger #12
Conversation
The color depth parameter has been added to the SpatialVideoMerger constructors and used to determine the profile level in SpatialVideoMerger. This option is also added to the SpatialMediaKitTool for user input. The default value for color depth has been set as 8.
|
Hi, this is in reference to #11. This is my first time using Xcode, so please let me know if I messed anything up. |
| @@ -62,6 +62,8 @@ OPTIONS: | |||
| -r, --right-file <right-file> | |||
| The right eye media file to merge. | |||
| -q, --quality <quality> Output video quality [0-100]. 50 is a good default value. | |||
| -c, --color-depth <color-depth> | |||
There was a problem hiding this comment.
I think this would make more sense as a boolean parameter, something like "--force-8-bit-color".
There was a problem hiding this comment.
Now that you mention it, a boolean makes much more sense. I think the force is just a bit misleading though. I believe without that parameter it will ALWAYS be 10bit. As far as I could tell, it is not trying to detect 8/10 bit. Is starting with parameter with a number bad practice or even allowed? Can you think of a better name?
There was a problem hiding this comment.
By convention, there's only a few verbs that are used with boolean flags. Perhaps the better name would be --disable-10-bit-color? My bias is towards 10-bit color by default, as the original intention of this tool was for combining professional intermediate codecs like ProRes, which are always 10-bit.
There was a problem hiding this comment.
I like it! Sorry I didn't have enough experience to think about the Boolean flag and naming convention. All of the 3D Blu-ray sources I have encountered are 8 bit. Probably due to the standards being older.
The color depth parameter has been added to the SpatialVideoMerger constructors and used to determine the profile level in SpatialVideoMerger. This option is also added to the SpatialMediaKitTool for user input. The default value for color depth has been set as 8.