Simplify media query regex for removing spaces #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penumbra1
changed the title
|
@penumbra1 can you rebase this against |
penumbra1
force-pushed
the
fix-media-regex
branch
from
4e77811 to
05f5706
Compare
quantizor
approved these changes
Jul 9, 2021
|
@probablyup Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mediaQueryRegex does not replace the space after
:if the media query has a calc, because the second capture group doesn't match it. E.g. for(max-width: calc(100px + 1px))the space is not replaced, sotoHaveStyledoesn't find the query.I think this regex should only be concerned with the
:situation, instead of matching all possible media queries. Then it wouldn't need fixes like #182.I've also removed unnecessary eslint-disable prettier/prettier comments.