Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest 21.0.0 compatibility: Make message in matchers a function #72

Merged

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Sep 5, 2017

Jest 21.0.0 and above expect result.message to be a function.

See jestjs/jest#3972 (commit jestjs/jest@b3d944e)

Jest 21.0.0 and above expect `result.message` to be a function.

See Jest commit:
jestjs/jest@b3d944e
@myabc
Copy link
Contributor Author

myabc commented Sep 5, 2017

⚠️ Removed the commits that actually update Jest (I'm not sure how best to test against multiple versions)

@MicheleBertoli
Copy link
Member

This is awesome, thanks @myabc.
I love the toThrowErrorMatchingSnapshot tests.
I think we could update Jest to v21 if we bump the major, but for now I'll just push a new minor since these changes are backwards compatible.

@MicheleBertoli MicheleBertoli merged commit e55ce90 into styled-components:master Sep 5, 2017
@myabc myabc deleted the bugfix/jest-21.0.0-compat branch September 5, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants