fix(hideVisually): remove clip-path from hideVisually
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `clip-path` harms performance during scroll events in Chrome. In the meantime, browsers can fall back to using `clip` until this bug in Chrome is fixed.
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 82 82
Lines 565 565
Branches 167 167
=====================================
Hits 565 565
Continue to review full report at Codecov.
|
ughitsaaron
commented
Jul 16, 2019
| return { | ||
| border: '0', | ||
| clip: 'rect(0 0 0 0)', | ||
| clipPath: 'inset(50%)', | ||
| // clipPath: 'inset(50%)', |
There was a problem hiding this comment.
Just to explain the decision here: I chose to comment this out instead of removing the line for posterity and to make it explicit that clip-path is not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this bug in Chrome recently, where the use of
clip-pathforces the browser to make unnecessary repaints. The conventional fix across several other libraries has been to simply fallback toclipwhile the bug is still unresolved. For instance,.sr-onlymixin and utility twbs/bootstrap#25197clip-pathh5bp/html5-boilerplate#2025clip-pathfromelement-invisiblemixin foundation/foundation-sites#10914Thanks for all your hard work on this library!