Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Link Component #954

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Updated Link Component #954

merged 2 commits into from
Dec 27, 2023

Conversation

b8zeek
Copy link
Contributor

@b8zeek b8zeek commented Nov 1, 2023

This pull request updates the Link component and enables accepting the target prop in order to enable opening of the links in a new tab. Updated tests and snapshots. Updated GitHub and Medium links, they are now being opened in a new tab.

🍀

@b8zeek
Copy link
Contributor Author

b8zeek commented Nov 3, 2023

@probablyup, I would appreciate if you can take a look at this pull request and close it. Cheers. 🍺

Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense :)

@quantizor quantizor enabled auto-merge (squash) December 27, 2023 16:13
@quantizor quantizor merged commit f398686 into styled-components:main Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants