Support typescript 3 style DefaultProps #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TypeScript 3.0 the way you can specify default props on a component is as follows:
Now inside
MyComponent
the propfoo
will be of typestring
but to the user of the component it will be typestring | undefined
.Currently in
react-docgen-typescript
the above will produce a props table that statesfoo
is required, even though this is not the case.My changes mark a prop as required only if it not optional and there is a code based default (i.e not a jsdoc default since that code wouldn't type check).
closes #129