Inferring type from constrained generics #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request modifies how generics are handled by the docgen typing generation, for better support for generic enums when used with storybook.
Consider the following case:
The current implementation makes the generated type to be T that storybook resolves to any.
With this change it's checked if the typing is constrained, and if so, obtains the typing from the constraint.
So when it resolves it will see the component definition as:
These are the changes that have been made: