Fix trimming of filenames #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
Obviously, it didn't come to my mind that I could break something with my "fix" #392. Thanks for your PR we have all these use cases covered now. It's surprising for me to see all that we need to handle and it's great to have it "documented" in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #392, trimming filenames no longer works properly on types coming from node_modules in a monorepo, where commands may be run from a particular package but dependencies are installed at the repo root (see #404 for more details).
This PR restores the previous behavior of returning the path starting from the first common root folder between the filename and
process.cwd(), in a way that should be reliable across platforms regardless of how paths are formatted.Fixes #404