Skip to content

Commit

Permalink
Remove npm update hack for Node.js. 14 on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
ybiquitous committed Feb 8, 2024
1 parent ecb2d3f commit 66d7f0a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,13 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: npm

# HACK: See https://github.com/npm/cli/issues/4341
- name: Workaround for npm installation failure on Node.js 14 and Windows
if: ${{ startsWith(matrix.node-version, '14') && startsWith(matrix.os, 'windows') }}
run: npm install --global npm@8.3

# NOTE: npm v10 has dropped support for Node.js v16.
- name: Install npm v9
if: ${{ startsWith(matrix.node-version, '16') || startsWith(matrix.node-version, '14') }}
if: ${{ startsWith(matrix.node-version, '16') }}
run: npm install --global npm@9 && npm --version

- name: Install latest npm
if: ${{ !startsWith(matrix.node-version, '16') && !startsWith(matrix.node-version, '14') }}
if: ${{ !startsWith(matrix.node-version, '16') }}
run: npm install --global npm@latest && npm --version

- name: Install dependencies
Expand Down

0 comments on commit 66d7f0a

Please sign in to comment.