Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value-no-vendor-prefix for -webkit-box #261

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes stylelint/stylelint#6372

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@ybiquitous ybiquitous force-pushed the set-value-no-vendor-prefix-ignore-values branch from b37aed0 to 9281b8e Compare October 1, 2022 15:19
@ybiquitous ybiquitous changed the title Change value-no-vendor-prefix to ignore -webkig-box Change value-no-vendor-prefix to ignore -webkit-box Oct 1, 2022
@jeddy3 jeddy3 changed the title Change value-no-vendor-prefix to ignore -webkit-box Fix value-no-vendor-prefix for -webkit-box Oct 2, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This can be a patch release as it makes the config more permissive.

@ybiquitous
Copy link
Member Author

This can be a patch release as it makes the config more permissive.

Thanks for your review. I agree. 👍🏼

@ybiquitous ybiquitous merged commit f569bb1 into main Oct 2, 2022
@ybiquitous ybiquitous deleted the set-value-no-vendor-prefix-ignore-values branch October 2, 2022 22:25
@Mouvedia
Copy link
Member

The -webkit-discard value behaves identically to discard, except that it only takes effect if the computed value of the display property on the parent is -webkit-box or -webkit-inline-box and the computed value of the -webkit-box-orient property on the parent is vertical.

Then shouldn't we add inline-box as well?

@ybiquitous
Copy link
Member Author

@Mouvedia Good catch. Can you please open a new pull request to add inline-box?

@Mouvedia
Copy link
Member

@ybiquitous I would if I could include -webkit-inline-box but exclude -moz-inline-box.
I don't know how to do that using ignoreValues.

@ybiquitous
Copy link
Member Author

@Mouvedia Indeed, the current rule implementation cannot do it. But that's also true for -moz-box, so inline-box would be acceptable.

If users hope more strict checks, they can override the config like this:

{
  "extends": ["stylelint-config-standard"],
  "rules": {
    "value-no-vendor-prefix": true
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix value-no-vendor-prefix false positives for -webkit-box
3 participants