Fix keyframe-block-no-duplicate-selectors/`keyframe-declaration-no-…

…important`/`keyframe-selector-notation`/`no-unknown-animations` false negatives for `@-o-keyframes` and `@-ms-keyframes` (#7953)
stylelint · Aug 26, 2024 · 83e2851 · 83e2851
1 parent 9744c18
commit 83e2851
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 8 deletions.
diff --git a/.changeset/spicy-wombats-wash.md b/.changeset/spicy-wombats-wash.md
@@ -0,0 +1,5 @@
+---
+"stylelint": minor
+---
+
+Fixed: `keyframe-block-no-duplicate-selectors`/`keyframe-declaration-no-important`/`keyframe-selector-notation`/`no-unknown-animations` false negatives for `@-o-keyframes` and `@-ms-keyframes`
diff --git a/lib/rules/keyframe-block-no-duplicate-selectors/index.cjs b/lib/rules/keyframe-block-no-duplicate-selectors/index.cjs
@@ -29,7 +29,7 @@ const rule = (primary) => {
 			return;
 		}
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			const selectors = new Set();
 
 			atRuleKeyframes.walkRules((keyframeRule) => {

diff --git a/lib/rules/keyframe-block-no-duplicate-selectors/index.mjs b/lib/rules/keyframe-block-no-duplicate-selectors/index.mjs
@@ -25,7 +25,7 @@ const rule = (primary) => {
 			return;
 		}
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			const selectors = new Set();
 
 			atRuleKeyframes.walkRules((keyframeRule) => {

diff --git a/lib/rules/keyframe-declaration-no-important/index.cjs b/lib/rules/keyframe-declaration-no-important/index.cjs
@@ -27,7 +27,7 @@ const rule = (primary) => {
 			return;
 		}
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			atRuleKeyframes.walkDecls((decl) => {
 				if (!decl.important) {
 					return;

diff --git a/lib/rules/keyframe-declaration-no-important/index.mjs b/lib/rules/keyframe-declaration-no-important/index.mjs
@@ -23,7 +23,7 @@ const rule = (primary) => {
 			return;
 		}
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			atRuleKeyframes.walkDecls((decl) => {
 				if (!decl.important) {
 					return;

diff --git a/lib/rules/keyframe-selector-notation/index.cjs b/lib/rules/keyframe-selector-notation/index.cjs
@@ -69,7 +69,7 @@ const rule = (primary) => {
 			},
 		});
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			const selectorsInBlock =
 				primary === 'percentage-unless-within-keyword-only-block'
 					? getSelectorsInBlock(atRuleKeyframes)

diff --git a/lib/rules/keyframe-selector-notation/index.mjs b/lib/rules/keyframe-selector-notation/index.mjs
@@ -65,7 +65,7 @@ const rule = (primary) => {
 			},
 		});
 
-		root.walkAtRules(/^(-(moz|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
+		root.walkAtRules(/^(-(o|moz|ms|webkit)-)?keyframes$/i, (atRuleKeyframes) => {
 			const selectorsInBlock =
 				primary === 'percentage-unless-within-keyword-only-block'
 					? getSelectorsInBlock(atRuleKeyframes)

diff --git a/lib/rules/no-unknown-animations/index.cjs b/lib/rules/no-unknown-animations/index.cjs
@@ -30,7 +30,7 @@ const rule = (primary) => {
 
 		const declaredAnimations = new Set();
 
-		root.walkAtRules(/(-(moz|webkit)-)?keyframes/i, (atRule) => {
+		root.walkAtRules(/(-(o|moz|ms|webkit)-)?keyframes/i, (atRule) => {
 			declaredAnimations.add(atRule.params);
 		});
 

diff --git a/lib/rules/no-unknown-animations/index.mjs b/lib/rules/no-unknown-animations/index.mjs
@@ -26,7 +26,7 @@ const rule = (primary) => {
 
 		const declaredAnimations = new Set();
 
-		root.walkAtRules(/(-(moz|webkit)-)?keyframes/i, (atRule) => {
+		root.walkAtRules(/(-(o|moz|ms|webkit)-)?keyframes/i, (atRule) => {
 			declaredAnimations.add(atRule.params);
 		});