Fix benchmark script #7504
Merged
Fix benchmark script #7504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the broken benchmark script (`npm run benchmark`)
The error reason is that `rules[ruleName]` has returned a `Promise` since 16.0.0.
```sh-session
$ npm run benchmark-rule -- value-keyword-case lower
...
const rule = ruleFunc(primary, secondary, context);
^
TypeError: ruleFunc is not a function
...
```
Also, this changes `parserOptions.ecmaVersion` in the ESLint config to allow top-level `await`.
|
|
Success! 🎉 $ npm run benchmark-rule -- value-keyword-case lower
> stylelint@16.2.0 benchmark-rule
> node scripts/benchmark-rule.mjs value-keyword-case lower
Warnings: 120
Mean: 223.59690633333332 ms
Deviation: 14.505605610006747 ms |
This was referenced Jan 30, 2024
Closed
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken benchmark script (
npm run benchmark)The error reason is that
rules[ruleName]has returned aPromisesince 16.0.0.Also, this changes
parserOptions.ecmaVersionin the ESLint config to allow top-levelawait.None.
If we release
eslint-config-stylelintincluding stylelint/eslint-config-stylelint#252 and bump the package version first, the ESLint config's change in this PR will be needless.Of course, we can revisit it later.