Fix tests warning #1173
Merged
Fix tests warning #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
commented
Mar 28, 2018
| @@ -1,6 +1,6 @@ | |||
| require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb') | |||
|
|
|||
| class TestZhCnLocale < Test::Unit::TestCase | |||
| class TestZhLocale < Test::Unit::TestCase | |||
There was a problem hiding this comment.
Take a look at the name of this file. Definitely copy and 🍝
vbrazo
commented
Mar 28, 2018
| @@ -29,10 +29,9 @@ def first_name | |||
| fetch('elder_scrolls.first_name') | |||
| end | |||
|
|
|||
| def first_name | |||
| def last_name | |||
There was a problem hiding this comment.
Fixing duplicated methods. Copy and 🍝 and adding specs for the new methods 👍
vbrazo
commented
Mar 28, 2018
| @@ -57,8 +57,7 @@ def test_omniauth_google_with_name | |||
| auth = @tester.google(name: custom_name) | |||
| info = auth[:info] | |||
| extra_raw_info = auth[:extra][:raw_info] | |||
| id_info = auth[:id_info] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
These variables are not being used. Why are we still declaring them? Copy and 🍝 again?
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…est-variables Fix tests warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created because of this issue #1171.
The goal is to clean up the warnings that appear when we run
bundle && bundle exec rake.first_namemethods). It should befirst_nameandlast_namefirst_nameandlast_namemethods