Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Seinfeld.business #1366

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Add Faker::Seinfeld.business #1366

merged 4 commits into from
Sep 17, 2018

Conversation

dsgraham
Copy link
Contributor

@dsgraham dsgraham commented Sep 17, 2018 •
edited by vbrazo
Loading

Checklist

  • Add Faker::Seinfeld.business
  • Add tests
  • Update doc/seinfeld.md

vbrazo
vbrazo approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Could you also update the docs/seinfeld.md and add the new method please?

@vbrazo vbrazo changed the title Add Faker::Seinfeld.business. Add Faker::Seinfeld.business Sep 17, 2018
@vbrazo vbrazo merged commit d737ee2 into faker-ruby:master Sep 17, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@dsgraham @vbrazo
Add Faker::Seinfeld.business (faker-ruby#1366)
19e3fe8 
* Add Faker::Seinfeld.business and associated test.

* Update documentation for Faker::Seinfeld

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@dsgraham dsgraham

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsgraham @vbrazo