fix: [AUTH-2047] disable fetch cache for all requests #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
logan-stytch
approved these changes
Oct 18, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "stytch", | |||
| "version": "9.0.4", | |||
| "version": "9.0.5", | |||
There was a problem hiding this comment.
Just reasoning through: I agree this is a PATCH bump since it fixes errant behavior and fixes a bug for people using Stytch in conjunction with a common framework. I was wondering at first if this should be a MINOR bump, but PATCH seems appropriate.
chris-stytch
approved these changes
Oct 18, 2023
max-stytch
added a commit
that referenced
this pull request
Oct 20, 2023
* fix: [AUTH-2047] disable fetch cache for all requests * 9.0.5
max-stytch
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes
cache: "no-store"into all requests made by the SDK in order to disable the NextJS v13+ Fetch Cache. We almost never want to cache responses from this client.Customers that do want to opt in to fetch cache behavior can use the workaround described in #262 (comment) to set a custom cache setting on the private
fetchConfig, which will override the value set in this PR.I'll open up another feature request issue for tracking adding support for custom
fetchoptions - either per client or per request.Closes #262