Bugs in CVolumetricMovement::ComputenNonconvexElements

[pcarruscag]

Describe the bug
A compiler warning brought me to this routine.
The logic to check for convexity of 3D elements seems flawed, I left two comments in the code in #1167 (it will be in develop soon enough) of what seems odd about it.
I think this routine was introduced in #1076, and it seems the intention is to check the volume of the tet associated with each corner of an element, a similar method is used in CPhysicalGeometry::Check_IntElem_Orientation.

I am not planning to fix this myself :)

[bigfooted]

I see the problem. With meson I use --warnlevel=3 but do not see a warning for this function, what do I need to do to see it?

[pcarruscag]

It is compiler dependent, I got the warning with clang with warnlevel 2, now it will probably not show the warning because I put an "if false" around that part of the code.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

[bigfooted]

sorry, stale bot, I'm still planning on fixing it, I just didn't have much time lately to work on it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.