-
Notifications
You must be signed in to change notification settings - Fork 918
Description
Describe the bug
If I set EQUIV_AREA to YES and prepare necessary near-field boundary marker in version 6.2.0, nearfield_flow.dat and Equivalent_Area.dat are output but not in version 7.0.0 anymore.
I did some investigation in the code. nearfield_flow.dat and Equivalent_Area.dat seem to be output by the code below in output_structure_legacy.cpp.
void COutputLegacy::SpecialOutput_SonicBoom
It is called out in void COutputLegacy::SetConvHistory_Body in output_structure_legacy.cpp. It is then called out in the following lines in CDriver.cpp but none of them seems to be for sonicboom case, which I think is the cause for this bug.
output_legacy->SetConvHistory_Body(&ConvHist_file[iZone][iInst], geometry_container, solver_container,
output_legacy->SetConvHistory_Body(&ConvHist_file[iZone][iInst], geometry_container, solver_container,
output_legacy->SetConvHistory_Body(NULL, geometry_container, solver_container, config_container,
In version 6.2.0, bool CDriver::Monitor(unsigned long ExtIter) in driver_structure.cpp had output->SetConvHistory_Body and I think this was eventually calling out SpecialOutput_SonicBoom. I think this function has been accidentally removed by the change below but I'm not sure how to fix it.
#724
It would be great if sonicboom case is included in the regression test of test cases. "biparabolic" uses this feature but does not seem to be included in the regression test. This test case does not converge at least on my computer though.
To Reproduce
v7_sonicboom.zip
NACA64206_sonicboom_v6.cfg is a config file for version 6.
NACA64206_sonicboom_v7.cfg is a config file for version 7.
The mesh file is common for both cases.
Desktop (please complete the following information):
- OS: Linux (Ubuntu 18.04.3 LTS)
- C++ compiler and version: g++ 7.4.0
- MPI implementation and version: OpenMPI 2.1.1
- SU2 Version: v6.2.0 and v7.0.0
Thank you in advance for your help.