Skip to content

add testcase for intersection prevention #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigfooted merged 7 commits into from
Jan 25, 2021
Merged

add testcase for intersection prevention #1158

bigfooted merged 7 commits into from
Jan 25, 2021

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Jan 9, 2021

Proposed Changes

added testcase to check and repair self-intersecting mesh and nonconvex cells after deformation

Related Work

fixes #1154, addition to implementation of #1076

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pcarruscag
Copy link
Member

pcarruscag commented Jan 9, 2021

Looks like the file is repeated?

@bigfooted
Copy link
Contributor Author

bigfooted commented Jan 10, 2021

Looks like the file is repeated?

Ah, forgot to remove the copy, thanks!

pcarruscag
pcarruscag approved these changes Jan 24, 2021
View reviewed changes
TestCases/deformation/intersection_prevention/def_intersect.cfg
Comment on lines +339 to +340
% Value of the shape deformation
DV_VALUE = 0, 0.0002, 0.0004, 0.0006, 0.0008, 0.001, 0.0012, 0.0014, 0.0016, 0.0018, 0.002, 0,-0.0002, -0.0004, -0.0006, -0.0008, -0.0010, -0.0012, -0.0014, -0.0016, -0.0018, -0.002
Copy link
Member

@pcarruscag pcarruscag Jan 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the prevention active for these values? If it is LGTM

Copy link
Contributor Author

@bigfooted bigfooted Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is the case from the thesis that gave problems. Thanks!

@bigfooted bigfooted merged commit 99b07fb into su2code:develop Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:chore PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigfooted @pcarruscag @WallyMaier