Skip to content

Remove mapping of global<->local marker IDs#1169

Merged
pcarruscag merged 1 commit intodevelopfrom
fix_global2local_v2
Jan 18, 2021
Merged

Remove mapping of global<->local marker IDs#1169
pcarruscag merged 1 commit intodevelopfrom
fix_global2local_v2

Conversation

@maxaehle
Copy link
Contributor

@maxaehle maxaehle commented Jan 18, 2021 •
edited
Loading

Proposed Changes

Remove unused CPhysicalGeometry::Local_to_Global_Marker, Global_to_Local_Marker

Related Work

#1110

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ X] I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • [ X] My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@maxaehle
Removed mapping of global<->local marker IDs
eb20f39 
as it was incomplete, and a global identifier is given through
the marker tag (except for SEND_RECEIVE markers).
@maxaehle maxaehle linked an issue Jan 18, 2021 that may be closed by this pull request
unused member CPhysicalGeometry::Local_to_Global_Marker #1110
Closed
@maxaehle maxaehle requested a review from pcarruscag January 18, 2021 13:33
@pcarruscag pcarruscag merged commit 23d3f41 into develop Jan 18, 2021
@pcarruscag pcarruscag deleted the fix_global2local_v2 branch January 18, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unused member CPhysicalGeometry::Local_to_Global_Marker

2 participants

@maxaehle @pcarruscag