Heat Transfer boundary condition

[oleburghardt]

Proposed Changes

As an alternative to MARKER_HEATFLUX = (heat_flux_marker, q,... ), this PR adds MARKER_HEATTRANSFER = (heat_transfer_marker, h, Twall) to the list of wall boundary conditions where the wall heat flux is computed by q = h*(Twall-Tref). h is the heat transfer coefficient, Tref is to be set by default or by a further option.

@bigfooted Is this what you've been thinking of? If so, I'd go ahead adding this to the compressible and the heat solver as well, if not, we should get this right for the incompressible solver first :-)

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
• My contribution is commented and consistent with SU2 style.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

[pcarruscag]

If you are planning to touch the heat solver, might I suggest you, @bigfooted, @danielmayer, and me get together like the power rangers and do the scalar solver thing properwise without grafting code from 10 versions ago into develop?

The ideia would be to create a CFVMSolverBase (in the style of the one for flow solvers) to cover:

• Turbulence solvers;
• Heat solver;
• Radiation solver;
• General passive/active scalar solvers;
• Eventual transition solvers;

The starting point would be the current base turbulence solver.

[oleburghardt]

If you are planning to touch the heat solver, might I suggest you, @bigfooted, @danielmayer, and me get together like the power rangers and do the scalar solver thing properwise without grafting code from 10 versions ago into develop?

The ideia would be to create a CFVMSolverBase (in the style of the one for flow solvers) to cover:

* Turbulence solvers;

* Heat solver;

* Radiation solver;

* General passive/active scalar solvers;

* Eventual transition solvers;

The starting point would be the current base turbulence solver.

I'm in. The heat solver should be easy to integrate into a generic framework if the framework provides a Laplacian/diffusion coefficient (which will then turn into thermal diffusivity). Apart from that, there's nothing very heat specific in the heat solver :)

[bigfooted]

If you are planning to touch the heat solver, might I suggest you, @bigfooted, @danielmayer, and me get together like the power rangers and do the scalar solver thing properwise without grafting code from 10 versions ago into develop?
The ideia would be to create a CFVMSolverBase (in the style of the one for flow solvers) to cover:

* Turbulence solvers;

* Heat solver;

* Radiation solver;

* General passive/active scalar solvers;

* Eventual transition solvers;

The starting point would be the current base turbulence solver.

I'm in. The heat solver should be easy to integrate into a generic framework if the framework provides a Laplacian/diffusion coefficient (which will then turn into thermal diffusivity). Apart from that, there's nothing very heat specific in the heat solver :)

Me too. I'm already cleaning up our code a bit so it's easier to see the differences and similarities.

[danielmayer]

If you are planning to touch the heat solver, might I suggest you, @bigfooted, @danielmayer, and me get together like the power rangers and do the scalar solver thing properwise without grafting code from 10 versions ago into develop?
The ideia would be to create a CFVMSolverBase (in the style of the one for flow solvers) to cover:

* Turbulence solvers;

* Heat solver;

* Radiation solver;

* General passive/active scalar solvers;

* Eventual transition solvers;

The starting point would be the current base turbulence solver.

I'm in. The heat solver should be easy to integrate into a generic framework if the framework provides a Laplacian/diffusion coefficient (which will then turn into thermal diffusivity). Apart from that, there's nothing very heat specific in the heat solver :)

Me too. I'm already cleaning up our code a bit so it's easier to see the differences and similarities.

Sure! Let's do this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

[TobiKattmann]

Reopening after chatting with @oleburghardt . I merged develop (which I hopefully made no mistakes in as there were quite some conflicts).
Left todo is imo (beyond possible further comments, possible failing tests etc):

• adding a testcase that at best serves as a verification/sanity check (the expected results of course have to be documented for a possible future redo). I'll see what i'll find
• take a second look at the cfg option consolidation for good measure

I would prefer if this PR would not tackle the CFVMScalarSolver thing, but a first WIP-PR into that direction will come to a github repository near you soon ;)

[pcarruscag]

You replace u by (rho u)/rho, that is also what gives derivatives wrt the momentum.

[TobiKattmann]

Alright, Heat-Transfer BC is good to go. Code factor does its usual thing with Complex code but the rest is green.
Was a bit more than I anticipated but now there is a compressible version as well alongside the incompressible.

An incompressible Testcase was added which briefly explains expected results in the extreme ends of heat transfer coefficient values.

What's is left to do for me is to update and merge su2code/su2code.github.io/pull/26 ,In there i will drop a comment or two that advertises the HeatTransfer bc.

Thanks @oleburghardt for kicking this off, @pedro for the review and advise and @bigfooted for some chats behind the scenes