Fixes in history output for time averaged and multizone problems #1259
Conversation
|
You could modify |
…ng time iteration
|
Hi Pedro, thanks for the idea to update the windowing directly! I've updated addValue such that the values are added for new time only (replaces existing values if it is still the same time iteration). This is a lot simpler and very happy to remove the convoluted logic. The SetUpdate_Averages was still necessary though to pass the regression test for unsteady_cylinder_windowed_average. |
| } | ||
| OutputScreenAndHistory(config); |
| bool CFlowCompOutput::SetUpdate_Averages(CConfig *config){ | ||
|
|
||
| return true; | ||
| return (config->GetTime_Marching() != TIME_MARCHING::STEADY && (curInnerIter == config->GetnInner_Iter() - 1 || convergence)); |
There was a problem hiding this comment.
It is strange that this would break the testcase, I'll have a look.
There was a problem hiding this comment.
Your initial change was correct, the logic was artificially delaying the update of the average to the end of the timestep, and the timedomain regressions check the first inner iteration by default.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
|
Hi Pedro, thanks for updating the regression test and all the tidy up as well. |
|
Hi @cvencro, thanks for those changes 💐 I added very small changes to another PR |
Proposed Changes
Improvements to time averaged history output for dynamic multizone problems, which now also include the structural zone. The averaging logic has been updated to include values only for the final solution in each time iteration.
To test the fixes in this PR, time averaged history output has been added to the existing dynamic fsi test case.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.