-
Notifications
You must be signed in to change notification settings - Fork 918
Add unsteady cht adjoint testcase #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request introduces 1 alert when merging 3548413 into 7b1ad11 - view on LGTM.com new alerts:
|
TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/postprocess.py
Outdated
Show resolved
Hide resolved
TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/chtMaster.cfg
Outdated
Show resolved
Hide resolved
pcarruscag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
|
Code Factor complains about 2 things which are negligible imo. Good'ol complex code in CSolver which I didn't even touch and wildcard import of FADO things |
Proposed Changes
Added files
parallel_reg_AD will fail until the Testcases PR 63 is merged.
Related Work
Depends on #1260 and contains all of those changes (i.e. best reviewed after that is merged .. or just look at the last commit :) ). Meant to be merged shortly after but before #1284 to have an additional safeguarded case.
PR Checklist