-
Notifications
You must be signed in to change notification settings - Fork 918
Fix for axisymmetric terms in NEMO + general NEMO updates #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
521b960
making initial updates
WallyMaier 61d68db
cleanup
WallyMaier c5f02cb
more fixes
6ff5768
Compiles, no segfaults
WallyMaier 5a4ae9f
addressing github compilation issues. also adding in electron/ionizat…
8445016
more github compiling fixes
WallyMaier addd126
more github compiling fixes
WallyMaier 7593aae
fixing ionization shift
WallyMaier fe817eb
fixing loop mistake causing mpi failures
WallyMaier 4a039f7
Apply suggestions from code review
pcarruscag 5dfd51d
address pr comments fixing some of the regressions
WallyMaier 69988a6
fix code issue warning
WallyMaier 398b356
update to develop
WallyMaier 9c9657e
removing sneaky conflict
WallyMaier ae0df98
updating regressions
WallyMaier 32b7c95
Apply suggestions from code review
pcarruscag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3601,14 +3601,6 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i | |
| SU2_MPI::Error("AUSMPW+ is extremely unstable. Feel free to fix me!", CURRENT_FUNCTION); | ||
| } | ||
|
|
||
| if (GetGasModel() == "ARGON" && GetKind_FluidModel() == SU2_NONEQ){ | ||
| SU2_MPI::Error("ARGON is not working with SU2_NONEQ fluid model!", CURRENT_FUNCTION); | ||
| } | ||
|
|
||
| if (GetKind_FluidModel() == MUTATIONPP && GetFrozen() == true){ | ||
| SU2_MPI::Error("The option of FROZEN_MIXTURE is not yet working with Mutation++ support.", CURRENT_FUNCTION); | ||
| } | ||
|
|
||
| if(GetBoolTurbomachinery()){ | ||
| nBlades = new su2double[nZone]; | ||
| FreeStreamTurboNormal= new su2double[3]; | ||
|
|
@@ -5042,7 +5034,8 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i | |
| /*--- Specifying a deforming surface requires a mesh deformation solver. ---*/ | ||
| if (GetSurface_Movement(DEFORMING)) Deform_Mesh = true; | ||
|
|
||
| if (GetGasModel() == "ARGON") monoatomic = true; | ||
| if (GetGasModel() == "ARGON") {monoatomic = true;} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prevents some issues with unintialized jumps |
||
| else {monoatomic = false;} | ||
|
|
||
| // This option is deprecated. After a grace period until 7.2.0 the usage warning should become an error. | ||
| if(OptionIsSet("CONV_CRITERIA") && rank == MASTER_NODE) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are now working.