-
Notifications
You must be signed in to change notification settings - Fork 917
Intermediate class of variable for all flow solver variables + Fix for MUSCL in NEMO solver #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pcarruscag LGTM! Thanks for putting in the work and abstracting more of the repeated routines. |
TobiKattmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pcarruscag 💐 Some generalization is always nice. I only a have a few minor points.
I'll try to finish #1330 (template the ScalarLayer on the specialized type of variable), so this can be merged
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
…nto base_flow_variable
Co-authored-by: Wally Maier <wallytmaier@gmail.com>
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
…nto base_flow_variable
Proposed Changes
Likewise for incompressible and NEMO.
CFlowVariable stores, allocates, and gives access to, primitives, their gradients and limiters, and a few other odd things.
For now this is just cleanup but it can be used to give non-virtual access to these flow variables to other solvers.
For example, the scalar solver #1330 can static_cast or dynamic_cast the nodes of the flow solver to access some quantities more efficiently.
I'll leave that for after #1330 is merged.
PR Checklist