Skip to content

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Sep 19, 2021

Proposed Changes

CVariable -> CFlowVariable -> CEulerVariable -> CNSVariable

Likewise for incompressible and NEMO.

CFlowVariable stores, allocates, and gives access to, primitives, their gradients and limiters, and a few other odd things.
For now this is just cleanup but it can be used to give non-virtual access to these flow variables to other solvers.
For example, the scalar solver #1330 can static_cast or dynamic_cast the nodes of the flow solver to access some quantities more efficiently.
I'll leave that for after #1330 is merged.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@WallyMaier
Copy link
Contributor

@pcarruscag LGTM! Thanks for putting in the work and abstracting more of the repeated routines.

@pcarruscag pcarruscag changed the title Intermediate class of variable for all flow solver variables Intermediate class of variable for all flow solver variables + Fix for MUSCL in NEMO solver Sep 20, 2021
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcarruscag 💐 Some generalization is always nice. I only a have a few minor points.

I'll try to finish #1330 (template the ScalarLayer on the specialized type of variable), so this can be merged

pcarruscag and others added 2 commits September 22, 2021 11:27
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
@pcarruscag pcarruscag merged commit 6338bff into develop Sep 25, 2021
@pcarruscag pcarruscag deleted the base_flow_variable branch September 25, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants