Skip to content

Fix possible segfault using SetConsVarGradient #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcarruscag merged 1 commit into from
Sep 30, 2021
Merged

Fix possible segfault using SetConsVarGradient #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions SU2_CFD/src/solvers/CNEMOEulerSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,8 +1591,6 @@ void CNEMOEulerSolver::BC_Far_Field(CGeometry *geometry, CSolver **solver_contai
/*--- Primitive variables, and gradient ---*/
visc_numerics->SetConservative(nodes->GetSolution(iPoint),
node_infty->GetSolution(0) );
visc_numerics->SetConsVarGradient(nodes->GetGradient(iPoint),
node_infty->GetGradient(0) );
Copy link
Contributor

@jtneedels jtneedels Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are unnecessary? Looks good to me otherwise, as long as this doesn't cause any issues.

visc_numerics->SetPrimitive(nodes->GetPrimitive(iPoint),
node_infty->GetPrimitive(0) );
visc_numerics->SetPrimVarGradient(nodes->GetGradient_Primitive(iPoint),
Expand Down Expand Up @@ -2119,8 +2117,6 @@ void CNEMOEulerSolver::BC_Outlet(CGeometry *geometry, CSolver **solver_container

// /*--- Conservative variables, and gradient ---*/
// visc_numerics->SetConservative(U_domain, U_outlet);
// visc_numerics->SetConsVarGradient(nodes->GetGradient(), node_infty->GetGradient() );


// /*--- Pass supplementary information to CNumerics ---*/
// visc_numerics->SetdPdU(nodes->GetdPdU(), node_infty->GetdPdU());
Expand Down
2 changes: 0 additions & 2 deletions SU2_CFD/src/solvers/CNEMONSSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,6 @@ void CNEMONSSolver::Viscous_Residual(CGeometry *geometry,
/*--- Primitive variables, and gradient ---*/
numerics->SetConservative (nodes->GetSolution(iPoint),
nodes->GetSolution(jPoint) );
numerics->SetConsVarGradient(nodes->GetGradient(iPoint),
nodes->GetGradient(jPoint) );
numerics->SetPrimitive (nodes->GetPrimitive(iPoint),
nodes->GetPrimitive(jPoint) );
numerics->SetPrimVarGradient(nodes->GetGradient_Primitive(iPoint),
Expand Down