Addition of catalytic isothermal wall boundary conditions in SU2-NEMO #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
WallyMaier
changed the title
WallyMaier
reviewed
Nov 2, 2021
pcarruscag
reviewed
Nov 3, 2021
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
WallyMaier
reviewed
Nov 4, 2021
Signed-off-by: jtneedels <jneedels@stanford.edu>
Contributor
|
I just updated to develop. Trying to "unstale" this. |
WallyMaier
reviewed
Apr 16, 2022
jtneedels
commented
Jul 1, 2022
Contributor
Author
jtneedels
left a comment
jtneedels
left a comment
There was a problem hiding this comment.
Are you sure signs are right for the coefficients in the partially catalytic wall, with the reaction tables you added?
WallyMaier
requested changes
Jul 1, 2022
Contributor
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
Im gonna put a hold on this PR until the code is verify to be working as expected.
WallyMaier
reviewed
Jul 22, 2022
| /*--- Surface energy balance: trans-rot heat flux, vib-el heat flux, | ||
| enthalpy transport due to mass diffusion ---*/ | ||
| HeatFlux[iMarker][iVertex] = thermal_conductivity_tr*dTn + thermal_conductivity_ve*dTven; | ||
| if (Marker_Tag == Catalytic_Tag){ |
Contributor
There was a problem hiding this comment.
@pcarruscag Is there a better way to do this? i.e. only do this for specific walls?
Member
There was a problem hiding this comment.
Sure, implement the IsCatalytic(marker_tag) in CConfig instead of having it inlined here.
WallyMaier
approved these changes
Oct 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Addition and cleanup of isothermal catalytic wall boundary, integration with rest of code. Code optimization of catalytic wall routines, removal of array allocations.
Submitting this draft PR primarily to get comments on approach, style, not looking to PR into develop quite yet.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.